Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redis setup from net.sh #33680

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

yihau
Copy link
Member

@yihau yihau commented Oct 12, 2023

Problem

system performance tests failed recently.

it seems that this line is the culprit

add-apt-repository -y ppa:chris-lea/redis-server

If I don't miss anything, we don't really use redis in our performance tests.

Summary of Changes

remove the redis setup from the net.sh

@yihau yihau changed the title remove redis setup for perf tests remove redis setup from net.sh Oct 12, 2023
@t-nelson
Copy link
Contributor

maybe this can all go? 9eb8b67

@mvines
Copy link
Member

mvines commented Oct 12, 2023

yep, nuke it. Redis was used by a very early version of the explorer, nothing more

@yihau yihau merged commit abfecad into solana-labs:master Oct 13, 2023
4 checks passed
@yihau yihau deleted the remove-redis-from-perf-tests branch October 13, 2023 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants