Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor - LoadedPrograms part 2 #33694

Merged
merged 5 commits into from
Oct 13, 2023

Conversation

Lichtso
Copy link
Contributor

@Lichtso Lichtso commented Oct 13, 2023

Problem

General fixes split off from #33477, continuation of #33482.

Summary of Changes

  • Uses one mock environment across all entries generated in each LoadedProgram test.
  • Adds LoadedProgramType::get_environment().
  • Adjusts test_runtime_feature_enable_with_program_cache().
  • Filter out entries of different environments in LoadedPrograms::extract().
  • Adds LoadedPrograms::get_environments_for_epoch().

@Lichtso Lichtso added the v1.17 PRs that should be backported to v1.17 label Oct 13, 2023
@Lichtso Lichtso requested a review from pgarg66 October 13, 2023 17:53
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #33694 (64038d2) into master (09e858d) will decrease coverage by 0.1%.
The diff coverage is 92.1%.

@@            Coverage Diff            @@
##           master   #33694     +/-   ##
=========================================
- Coverage    81.8%    81.8%   -0.1%     
=========================================
  Files         806      806             
  Lines      217676   217684      +8     
=========================================
- Hits       178220   178217      -3     
- Misses      39456    39467     +11     

@pgarg66 pgarg66 merged commit a3f85ab into solana-labs:master Oct 13, 2023
31 checks passed
mergify bot pushed a commit that referenced this pull request Oct 13, 2023
(cherry picked from commit a3f85ab)

# Conflicts:
#	runtime/src/bank/tests.rs
@Lichtso Lichtso deleted the refactor/loaded_programs branch October 13, 2023 20:44
mergify bot added a commit that referenced this pull request Oct 13, 2023
* Refactor - LoadedPrograms part 2 (#33694)

(cherry picked from commit a3f85ab)

# Conflicts:
#	runtime/src/bank/tests.rs

* fix merge conflicts

---------

Co-authored-by: Alexander Meißner <AlexanderMeissner@gmx.net>
Co-authored-by: Pankaj Garg <pankaj@solana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.17 PRs that should be backported to v1.17
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants