ancient shrink on its own cadence #33712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #33712 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 806 806
Lines 217867 217872 +5
=========================================
- Hits 178260 178246 -14
- Misses 39607 39626 +19 |
jeffwashington
added a commit
to jeffwashington/solana
that referenced
this pull request
Oct 16, 2023
mergify bot
pushed a commit
that referenced
this pull request
Nov 14, 2023
(cherry picked from commit d948e5b)
jeffwashington
added a commit
that referenced
this pull request
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Previously ancient shrink was run when shrink ran.
The code in accounts background service ended up running ancient shrink every 100ms in some cases. This is very inefficient.
Summary of Changes
Run ancient shrink on roughly the same cadence as clean. Also, run ancient shrink prior to creating a snapshot.
Fixes #