Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add metric for ancient can't move slots #33713

Merged
merged 4 commits into from
Oct 17, 2023

Conversation

jeffwashington
Copy link
Contributor

Problem

When we are packing ancient append vecs, the current strategy is to not move accounts from a slot for all accounts with refcounts > 1. This is because we can't know easily what other slot(s) the older versions of the account are in. Thus, it isn't safe to move slots.

Summary of Changes

Add a metric to keep track of how many slots fit this criteria.

Fixes #

HaoranYi
HaoranYi previously approved these changes Oct 16, 2023
Copy link
Contributor

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #33713 (87f8db3) into master (167dac2) will increase coverage by 0.0%.
Report is 4 commits behind head on master.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##           master   #33713   +/-   ##
=======================================
  Coverage    81.8%    81.8%           
=======================================
  Files         806      806           
  Lines      217867   217875    +8     
=======================================
+ Hits       178260   178307   +47     
+ Misses      39607    39568   -39     

brooksprumo
brooksprumo previously approved these changes Oct 16, 2023
Copy link
Contributor

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm!

@jeffwashington jeffwashington merged commit 5de9163 into solana-labs:master Oct 17, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants