-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add metric for ancient can't move slots #33713
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov Report
@@ Coverage Diff @@
## master #33713 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 806 806
Lines 217867 217875 +8
=======================================
+ Hits 178260 178307 +47
+ Misses 39607 39568 -39 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, lgtm!
Problem
When we are packing ancient append vecs, the current strategy is to not move accounts from a slot for all accounts with refcounts > 1. This is because we can't know easily what other slot(s) the older versions of the account are in. Thus, it isn't safe to move slots.
Summary of Changes
Add a metric to keep track of how many slots fit this criteria.
Fixes #