Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in feature_set.rs #33777

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

ripatel-fd
Copy link
Contributor

Problem

Summary of Changes

Fixes #

@mergify mergify bot added community Community contribution need:merge-assist labels Oct 20, 2023
@mergify mergify bot requested a review from a team October 20, 2023 03:24
@steviez steviez added the CI Pull Request is ready to enter CI label Oct 20, 2023
@solana-grimes solana-grimes removed the CI Pull Request is ready to enter CI label Oct 20, 2023
Copy link
Contributor

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This should be safe given that those strings are only for display purpose in the CLI and do not effect the actual feature set id hash:

let mut feature_ids = FEATURE_NAMES.keys().collect::<Vec<_>>();

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #33777 (6cd99e7) into master (fb80288) will decrease coverage by 0.1%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #33777     +/-   ##
=========================================
- Coverage    81.8%    81.8%   -0.1%     
=========================================
  Files         807      807             
  Lines      218024   218024             
=========================================
- Hits       178449   178435     -14     
- Misses      39575    39589     +14     

@steviez steviez merged commit 6798e05 into solana-labs:master Oct 20, 2023
25 checks passed
@ripatel-fd ripatel-fd deleted the ripatel/secp256k1-typo branch October 20, 2023 12:26
@ripatel-fd
Copy link
Contributor Author

Thanks! This should be safe given that those strings are only for display purpose in the CLI and do not effect the actual feature set id hash:

For completeness, the feature accounts don't contain the descriptions either. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution need:merge-assist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants