CLI remove unwrap_or_default() on rpc calls #33782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arrowana
changed the title
Arrowana
force-pushed
the
fix/cli-rpc-silently-failing
branch
from
263c5bf
to
df1825c
Compare
Codecov Report
@@ Coverage Diff @@
## master #33782 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 806 806
Lines 217894 217893 -1
=======================================
+ Hits 178252 178276 +24
+ Misses 39642 39617 -25 |
joncinque
approved these changes
Oct 20, 2023
|
Just ran into this, thanks for fixing @Arrowana! |
mergify bot
pushed a commit
that referenced
this pull request
Nov 13, 2023
(cherry picked from commit e1a9f8e)
willhickey
pushed a commit
that referenced
this pull request
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When calling some cli commands it might return an incorrect results because the RPC node calls failures are swallowed silently
Running this several times illustrates the problem, some features are disappearing
solana feature status -umDoesn't work well because of the limitation of the public RPC, as a result the printed result is quite unstableSummary of Changes
Avoid
.unwrap_or_default()?instead to propagate the errorNow the CLI call above gives
Error: RPC response error -32602: Too many inputs provided; max 5Fixes #