Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo registry server updates to download crates #33805

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

pgarg66
Copy link
Contributor

@pgarg66 pgarg66 commented Oct 21, 2023

Problem

cargo fetch need fixes, as it currently doesn't return a crate package.

Summary of Changes

  • Return the crate package as response to the download command
  • Use base16 for program ID. Using base58 doesn't work as it is case sensitive, and fetch uses lower case for all the values
  • Return just the crate file, and do not include meta data information.

Fixes #

@pgarg66 pgarg66 marked this pull request as ready for review October 21, 2023 03:54
@pgarg66 pgarg66 requested a review from Lichtso October 21, 2023 03:54
@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Merging #33805 (a741b33) into master (6fd0dcb) will decrease coverage by 0.1%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #33805     +/-   ##
=========================================
- Coverage    81.8%    81.8%   -0.1%     
=========================================
  Files         806      806             
  Lines      217428   217428             
=========================================
- Hits       178056   178040     -16     
- Misses      39372    39388     +16     

@pgarg66 pgarg66 merged commit 0fc2c9f into solana-labs:master Oct 23, 2023
28 checks passed
@pgarg66 pgarg66 deleted the cargo-fetch-package branch October 23, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants