Use program cache fork graph in extract() #33806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgarg66
force-pushed
the
use-global-fork-graph
branch
from
61f8e0b
to
c03b38c
Compare
pgarg66
force-pushed
the
use-global-fork-graph
branch
from
f0583ba
to
9f0c4b6
Compare
pgarg66
force-pushed
the
use-global-fork-graph
branch
2 times, most recently
from
dfc4263
to
5a84a39
Compare
pgarg66
force-pushed
the
use-global-fork-graph
branch
from
5a84a39
to
e8a4baa
Compare
Codecov Report
@@ Coverage Diff @@
## master #33806 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 809 809
Lines 217717 217692 -25
=========================================
- Hits 178345 178309 -36
- Misses 39372 39383 +11 |
Lichtso
approved these changes
Oct 25, 2023
pgarg66
changed the title
mergify bot
pushed a commit
that referenced
this pull request
Oct 25, 2023
* Use program cache fork graph instead of WorkingSlot trait * Fix deadlocked tests * keep WorkingSlot trait for now (cherry picked from commit 78c31aa)
anwayde
pushed a commit
to firedancer-io/solana
that referenced
this pull request
Nov 16, 2023
…labs#33806) (solana-labs#33862) Use program cache fork graph in extract() (solana-labs#33806) * Use program cache fork graph instead of WorkingSlot trait * Fix deadlocked tests * keep WorkingSlot trait for now (cherry picked from commit 78c31aa) Co-authored-by: Pankaj Garg <pankaj@solana.com>
anwayde
pushed a commit
to firedancer-io/solana
that referenced
this pull request
Nov 16, 2023
…labs#33806) (solana-labs#33862) Use program cache fork graph in extract() (solana-labs#33806) * Use program cache fork graph instead of WorkingSlot trait * Fix deadlocked tests * keep WorkingSlot trait for now (cherry picked from commit 78c31aa) Co-authored-by: Pankaj Garg <pankaj@solana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
WorkingSlottrait could be replaced with the global instance ofForkGrpah.Summary of Changes
Use the global
ForkGraphif it's available. Otherwise, use the providedWorkingSlot.Updated unit tests.
Fixes #