Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove IncludeSlotInHash after feature activation on mnb #33816

Merged
merged 5 commits into from
Oct 23, 2023

Conversation

jeffwashington
Copy link
Contributor

Problem

Feature was activated, so this code can be removed for simplicity going forward.

Summary of Changes

Fixes #

brooksprumo
brooksprumo previously approved these changes Oct 23, 2023
Copy link
Contributor

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #33816 (9d2bcec) into master (669bc43) will decrease coverage by 0.1%.
Report is 5 commits behind head on master.
The diff coverage is 96.8%.

@@            Coverage Diff            @@
##           master   #33816     +/-   ##
=========================================
- Coverage    81.8%    81.8%   -0.1%     
=========================================
  Files         807      807             
  Lines      217406   217295    -111     
=========================================
- Hits       178021   177922     -99     
+ Misses      39385    39373     -12     

@jeffwashington jeffwashington marked this pull request as ready for review October 23, 2023 22:11
@jeffwashington jeffwashington merged commit b0b4e1f into solana-labs:master Oct 23, 2023
32 checks passed
HaoranYi pushed a commit to HaoranYi/solana that referenced this pull request Nov 8, 2023
…#33816)

* remove IncludeSlotInHash after feature activation on mnb

* fix compile errors

* compile errors

* fix tests

* fix test results
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants