adds metrics to turbine QUIC endpoint #33819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #33819 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 809 807 -2
Lines 217643 217523 -120
=========================================
- Hits 178247 178119 -128
- Misses 39396 39404 +8 |
steviez
reviewed
Oct 24, 2023
|
|
||
| fn record_error(err: &Error, stats: &TurbineQuicStats) { | ||
| match err { | ||
| Error::CertificateError(_) => (), |
There was a problem hiding this comment.
I see we do nothing for several cases; do we just not really expect these to happen at all? Even if we don't break them all out individually, should we make a "other" case as a catch-all so do account for all possible errors?
There was a problem hiding this comment.
CertificateError,TlsErrorandIoErrorcan only happen during start-up and are passed up the callstack which causes panic: https://github.com/solana-labs/solana/blob/8e0acf481/core/src/validator.rs#L1175-L1189ChannelSendErroronly happens during shutdown where downstream processes have winded down and the receiver end of the channel is dropped.SendDatagramError::Disabledcan never happen because that is a local config and we obviously are not disabling datagrams when starting the endpoint.
There was a problem hiding this comment.
Got it, thanks for the explanation
behzadnouri
force-pushed
the
turbine-quic-metrics
branch
from
0c65440
to
8e05575
Compare
steviez
approved these changes
Oct 24, 2023
behzadnouri
added
the
automerge
mergify bot
pushed a commit
that referenced
this pull request
Oct 24, 2023
(cherry picked from commit 6470544)
anwayde
pushed a commit
to firedancer-io/solana
that referenced
this pull request
Nov 16, 2023
…#33819) (solana-labs#33838) adds metrics to turbine QUIC endpoint (solana-labs#33819) (cherry picked from commit 6470544) Co-authored-by: behzad nouri <behzadnouri@gmail.com>
anwayde
pushed a commit
to firedancer-io/solana
that referenced
this pull request
Nov 16, 2023
…#33819) (solana-labs#33838) adds metrics to turbine QUIC endpoint (solana-labs#33819) (cherry picked from commit 6470544) Co-authored-by: behzad nouri <behzadnouri@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
monitor turbine QUIC endpoint
Summary of Changes
added metrics.