exits send_datagram_task if the connection is closed #33836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behzadnouri
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #33836 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 819 819
Lines 220228 220230 +2
=========================================
- Hits 180535 180528 -7
- Misses 39693 39702 +9 |
behzadnouri
force-pushed
the
turbine-quic-select
branch
from
e36baa5
to
408114b
Compare
github-actions
bot
added
the
stale
behzadnouri
removed
the
stale
behzadnouri
force-pushed
the
turbine-quic-select
branch
from
408114b
to
ec98352
Compare
github-actions
bot
added
the
stale
behzadnouri
removed
the
stale
behzadnouri
force-pushed
the
turbine-quic-select
branch
from
ec98352
to
97af274
Compare
joncinque
approved these changes
Dec 5, 2023
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
mergify bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
Waiting on receiver.recv() can unnecessarily block while the connection is already closed. The commit exits send_datagram_task if the connection is closed. (cherry picked from commit 03fbe08)
behzadnouri
added a commit
that referenced
this pull request
Dec 5, 2023
… of #33836) (#34327) exits send_datagram_task if the connection is closed (#33836) Waiting on receiver.recv() can unnecessarily block while the connection is already closed. The commit exits send_datagram_task if the connection is closed. (cherry picked from commit 03fbe08) Co-authored-by: behzad nouri <behzadnouri@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Waiting on
receiver.recv()can unnecessarily block while the connection is already closed.Summary of Changes
Exit
send_datagram_taskif the connection is closed