validator: deprecates --disable-accounts-disk-index
#33850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-nelson
added
v1.16
Codecov Report
@@ Coverage Diff @@
## master #33850 +/- ##
=========================================
- Coverage 81.9% 81.8% -0.1%
=========================================
Files 809 809
Lines 217712 217711 -1
=========================================
- Hits 178310 178297 -13
- Misses 39402 39414 +12 |
brooksprumo
approved these changes
Nov 4, 2023
i think 1.16 will be ok. we only deprecate here, so worst that happens is the operators who actually look at their logs will see a warning message on startup |
mergify bot
pushed a commit
that referenced
this pull request
Nov 14, 2023
* validator: deprecates `--disable-accounts-disk-index` * Fix checks failure * Move disable_accounts_disk_index arg to alphabetical order --------- Co-authored-by: Will Hickey <will.hickey@solana.com> (cherry picked from commit c55a6e5) # Conflicts: # validator/src/cli.rs
mergify bot
pushed a commit
that referenced
this pull request
Nov 14, 2023
* validator: deprecates `--disable-accounts-disk-index` * Fix checks failure * Move disable_accounts_disk_index arg to alphabetical order --------- Co-authored-by: Will Hickey <will.hickey@solana.com> (cherry picked from commit c55a6e5)
t-nelson
added a commit
that referenced
this pull request
Nov 15, 2023
* validator: deprecates `--disable-accounts-disk-index` * Fix checks failure * Move disable_accounts_disk_index arg to alphabetical order --------- Co-authored-by: Will Hickey <will.hickey@solana.com> (cherry picked from commit c55a6e5) # Conflicts: # validator/src/cli.rs
t-nelson
added a commit
that referenced
this pull request
Nov 15, 2023
…t of #33850) (#34070) validator: deprecates `--disable-accounts-disk-index` (#33850) * validator: deprecates `--disable-accounts-disk-index` * Fix checks failure * Move disable_accounts_disk_index arg to alphabetical order --------- Co-authored-by: Will Hickey <will.hickey@solana.com> (cherry picked from commit c55a6e5) Co-authored-by: Trent Nelson <trent@solana.com>
t-nelson
added a commit
that referenced
this pull request
Nov 16, 2023
…t of #33850) (#34069) validator: deprecates `--disable-accounts-disk-index` (#33850) * validator: deprecates `--disable-accounts-disk-index` * Fix checks failure * Move disable_accounts_disk_index arg to alphabetical order --------- Co-authored-by: Will Hickey <will.hickey@solana.com> (cherry picked from commit c55a6e5) # Conflicts: # validator/src/cli.rs Co-authored-by: Trent Nelson <trent@solana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
accounts disk index is the future, but we still offer a flag to disable it. every operator silently reverting to old behavior is going to be a problem when we need to drop support.
Summary of Changes
reduce the burden today. deprecate the flag