Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update upload_confirmed_blocks() return value when no blocks to upload #33861

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Update upload_confirmed_blocks() return value when no blocks to upload #33861

merged 1 commit into from
Oct 26, 2023

Commits on Oct 25, 2023

  1. Update upload_confirmed_blocks() return value when no blocks to upload 

    upload_confirmed_blocks() states that it will return the passed in
ending_slot when there are no blocks to upload. This is enforced in one
early return but not the other. The result is that BigTableUploadService
could potentially get stuck in a loop of trying to upload the same slot.

While this case seems to be caused when an operator restarts their node
with a fetched snapshot that causes a gap, we can still be friendly and
allow them to break out of this loop.
    @steviez
    steviez committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    50eaa6f View commit details
    Browse the repository at this point in the history