Geyser: return real parent blockhash, or default #33873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #33873 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 810 810
Lines 219291 219293 +2
=========================================
- Hits 179691 179667 -24
- Misses 39600 39626 +26 |
CriesofCarrots
force-pushed
the
geyser-parent-blockhash
branch
from
507cefc
to
9892266
Compare
|
I am proposing a v1.17 backport of this one, since it is a bug fix to geyser data |
mergify bot
pushed a commit
that referenced
this pull request
Nov 6, 2023
Return real parent blockhash, or default (cherry picked from commit d6ac9be)
anwayde
pushed a commit
to firedancer-io/solana
that referenced
this pull request
Nov 16, 2023
…olana-labs#33873) (solana-labs#33959) Geyser: return real parent blockhash, or default (solana-labs#33873) Return real parent blockhash, or default (cherry picked from commit d6ac9be) Co-authored-by: Tyera <tyera@solana.com>
anwayde
pushed a commit
to firedancer-io/solana
that referenced
this pull request
Nov 16, 2023
…olana-labs#33873) (solana-labs#33959) Geyser: return real parent blockhash, or default (solana-labs#33873) Return real parent blockhash, or default (cherry picked from commit d6ac9be) Co-authored-by: Tyera <tyera@solana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Geyser's
notify_block_metadata()callsBank::parent_hash()to populate itsparent_blockhashfield. ButBank::parent_hash()returns a bank hash, not a blockhash (ie. latest blockhash in the bank).Summary of Changes
Update code to get the correct parent_blockhash. This currently includes an
unwrap_or_default, becauseBank::parent()returns an Option. Before merging this, we need to understand in what situations the parent bank would be None when this notification is triggered.Fixes #33829