chunk all ancient append vecs #33909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #33909 +/- ##
=======================================
Coverage 81.9% 81.9%
=======================================
Files 811 811
Lines 219335 219356 +21
=======================================
+ Hits 179710 179758 +48
+ Misses 39625 39598 -27 |
HaoranYi
force-pushed
the
oc18
branch
2 times, most recently
from
5c5e535
to
d3dc2f7
Compare
brooksprumo
reviewed
Nov 6, 2023
Yeah. |
Co-authored-by: Brooks <brooks@prumo.org>
Co-authored-by: Brooks <brooks@prumo.org>
brooksprumo
reviewed
Nov 6, 2023
jeffwashington
commented
Nov 6, 2023
accounts-db/src/accounts_hash.rs
Outdated
| @@ -250,6 +253,21 @@ impl HashStats { | |||
| ("collect_snapshots_us", self.collect_snapshots_us, i64), | |||
| ("num_snapshot_storage", self.num_snapshot_storage, i64), | |||
| ("scan_chunks", self.scan_chunks, i64), | |||
| ( | |||
There was a problem hiding this comment.
Maybe these stats already do what you are after?
solana/accounts-db/src/cache_hash_data_stats.rs
Lines 39 to 53 in 8c69a0e
There was a problem hiding this comment.
Yeah. These stats are what I want. I removed the redundant stats that I added.
|
lgtm. thanks, @HaoranYi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When we pack ancient vecs, we end up with non-ancient append vecs interleaved with ancient append vecs.
This ends up causing hash calculation to take much longer. Hash Calculation is very sensitive to the # of chunks.
The current chunking algorithm assumes the model of appending ancient append vecs.
Summary of Changes
Just create ranges instead.
The blue line that drops here is restarting with the removal of the ancient splitter algorithm (this pr).
Here's the overall hash calc time with removing this code:
Fixes #