Remove RwLock on TransactionNotifier #33962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #33962 +/- ##
=======================================
Coverage 81.9% 81.9%
=======================================
Files 811 811
Lines 219329 219327 -2
=======================================
+ Hits 179696 179708 +12
+ Misses 39633 39619 -14 |
CriesofCarrots
approved these changes
Nov 7, 2023
|
This is true of all notifies: |
Yes. Getting rid of them in a few PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The RwLock on TransactionNotify interface is unnecessary as there is no method need write protection.
Summary of Changes
Remove unnecessary RwLock on TransactionNotify in geyser
Fixes #