Removes Default from RollingBitField #33969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #33969 +/- ##
=======================================
Coverage 81.9% 81.9%
=======================================
Files 811 811
Lines 218163 218163
=======================================
+ Hits 178734 178765 +31
+ Misses 39429 39398 -31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
RollingBitField derives
Default, but this is not safe nor valid.A default RollingBitField will have
max_widthset to zero. One of the RollingBitField's invariants is thatmax_widthis greater than zero. This is becausemax_widthis used with modulo to compute the address from a given key, and zero is not allowed here.Summary of Changes
Do not derive Default.