Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.17: Add --release-with-debug option to cargo-install-all.sh (backport of #33383) #33978

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 7, 2023

This is an automatic backport of pull request #33383 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Add --canary option to cargo-install-all for building with separate debug symbols

* lint

* Remove debug-assertions

* switch flag from --canary to --release-with-debug

(cherry picked from commit 87b4dc6)
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #33978 (9779588) into v1.17 (9779588) will not change coverage.
The diff coverage is n/a.

❗ Current head 9779588 differs from pull request most recent head f66b0dc. Consider uploading reports for the commit f66b0dc to get more accurate results

@@           Coverage Diff           @@
##            v1.17   #33978   +/-   ##
=======================================
  Coverage    81.8%    81.8%           
=======================================
  Files         803      803           
  Lines      217864   217864           
=======================================
  Hits       178337   178337           
  Misses      39527    39527           

@willhickey willhickey merged commit 7089f1e into v1.17 Nov 10, 2023
15 checks passed
@willhickey willhickey deleted the mergify/bp/v1.17/pr-33383 branch November 10, 2023 19:34
anwayde pushed a commit to firedancer-io/solana that referenced this pull request Nov 16, 2023
…ort of solana-labs#33383) (solana-labs#33978)

Add --release-with-debug option to cargo-install-all.sh (solana-labs#33383)

* Add --canary option to cargo-install-all for building with separate debug symbols

* lint

* Remove debug-assertions

* switch flag from --canary to --release-with-debug

(cherry picked from commit 87b4dc6)

Co-authored-by: Will Hickey <will.hickey@solana.com>
anwayde pushed a commit to firedancer-io/solana that referenced this pull request Nov 16, 2023
…ort of solana-labs#33383) (solana-labs#33978)

Add --release-with-debug option to cargo-install-all.sh (solana-labs#33383)

* Add --canary option to cargo-install-all for building with separate debug symbols

* lint

* Remove debug-assertions

* switch flag from --canary to --release-with-debug

(cherry picked from commit 87b4dc6)

Co-authored-by: Will Hickey <will.hickey@solana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants