Add Blockstore::get_rooted_block_with_entries method #33995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #33995 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 811 811
Lines 219339 219366 +27
=========================================
+ Hits 179699 179717 +18
- Misses 39640 39649 +9 |
CriesofCarrots
commented
Nov 9, 2023
steviez
reviewed
Nov 9, 2023
steviez
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is interest in storing entry data in BigTable for redundancy. The BigTable uploader uses
Blockstore::get_rooted_block()which flattens all the transactions in the block. But since it's already looping through all entries, this seems like the right place to collect Entry data as well.Summary of Changes
Add helper structs and method to support a new
Blockstore::get_rooted_block_with_entries()