Uses fold+reduce for handling duplicate pubkeys during index generation #34011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #34011 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 811 811
Lines 219412 219428 +16
=========================================
+ Hits 179792 179797 +5
- Misses 39620 39631 +11 |
brooksprumo
force-pushed
the
generate-index/uncleaned-roots/reduce
branch
from
5c414c2
to
7512e9a
Compare
brooksprumo
commented
Nov 10, 2023
Comment on lines
-9443
to
-9444
| self.accounts_index | ||
| .add_uncleaned_roots(uncleaned_roots.into_iter()); |
There was a problem hiding this comment.
This was moved up into the block that makes uncleaned_roots. Same for the other "removed" lines just above here.
brooksprumo
commented
Nov 10, 2023
Comment on lines
+9460
to
+9465
| accounts_data_len_dedup_timer.stop(); | ||
| timings.accounts_data_len_dedup_time_us = accounts_data_len_dedup_timer.as_us(); | ||
| timings.slots_to_clean = uncleaned_roots.len() as u64; | ||
|
|
||
| self.accounts_index | ||
| .add_uncleaned_roots(uncleaned_roots.into_iter()); |
There was a problem hiding this comment.
Following from https://github.com/solana-labs/solana/pull/34011/files#r1389679091, those lines were moved here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When generating the index we visit duplicate pubkeys to get uncleaned roots and also the accounts data len from those duplicates. This visitation is farmed out to multiple threads with rayon. To capture the results, we currently use a mutex. This causes undue communication and contention between these threads, since rayon has primitives for doing these reductions.
Summary of Changes
Replace the mutex with an impl that uses Rayon's
foldandreduce.Results
Using ledger-tool and a recent mnb snapshot, I compared master (as of
69ab8a8234) to this PR. Since this change only impacts index generation, I only looked at that metric, and specifically theaccounts_data_len_dedup_time_usdatapoint:1,974,4731,700,625273,848So not huge, but it's something!