Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move load_accounts to runtime #34017

Merged
merged 5 commits into from
Nov 16, 2023
Merged

Move load_accounts to runtime #34017

merged 5 commits into from
Nov 16, 2023

Conversation

LucasSte
Copy link
Contributor

Problem

Accounts::load_accounts is used only in runtime and needs only two functions from AccoutnsDb as a dependency. The code is better suited to the runtime folder.

Summary of Changes

I moved Accounts::load_accounts and its dependencies to runtime/accounts.

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #34017 (4204ea6) into master (60fdd85) will decrease coverage by 0.1%.
Report is 2 commits behind head on master.
The diff coverage is 96.9%.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #34017     +/-   ##
=========================================
- Coverage    81.9%    81.9%   -0.1%     
=========================================
  Files         816      817      +1     
  Lines      219751   219760      +9     
=========================================
+ Hits       180027   180033      +6     
- Misses      39724    39727      +3     

@LucasSte LucasSte marked this pull request as ready for review November 10, 2023 18:49
@brooksprumo
Copy link
Contributor

Also FYI, when addressing PR feedback and pushing those changes, using force-push often makes it harder for me as a reviewer to re-review and actually see what has changed. There's no exact science, but I do recommend against force-pushing when possible.

Also refer to https://github.com/solana-labs/solana/blob/master/CONTRIBUTING.md#is-your-pr-easy-to-say-yes-to. It has some guidance on force-pushing as well.

Thanks!

@LucasSte
Copy link
Contributor Author

Also FYI, when addressing PR feedback and pushing those changes, using force-push often makes it harder for me as a reviewer to re-review and actually see what has changed. There's no exact science, but I do recommend against force-pushing when possible.

Also refer to https://github.com/solana-labs/solana/blob/master/CONTRIBUTING.md#is-your-pr-easy-to-say-yes-to. It has some guidance on force-pushing as well.

Thanks!

Thanks for the guidance. I'll keep an eye on that document for further contributions.

@LucasSte LucasSte merged commit 2c71d21 into solana-labs:master Nov 16, 2023
32 checks passed
@LucasSte LucasSte deleted the load-accoutns branch November 16, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants