cpi: fix capacity check in update_caller_account #34064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reserve(additional) reserves additional bytes on top of the current _length_ not capacity. Before this fix we could potentially reserve less capacity than required.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34064 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 811 811
Lines 219628 219629 +1
=========================================
- Hits 179974 179915 -59
- Misses 39654 39714 +60 |
Lichtso
approved these changes
Nov 15, 2023
mergify bot
pushed a commit
that referenced
this pull request
Nov 15, 2023
reserve(additional) reserves additional bytes on top of the current _length_ not capacity. Before this fix we could potentially reserve less capacity than required. (cherry picked from commit d009d73)
alessandrod
added a commit
that referenced
this pull request
Nov 15, 2023
…34064) (#34081) cpi: fix capacity check in update_caller_account (#34064) reserve(additional) reserves additional bytes on top of the current _length_ not capacity. Before this fix we could potentially reserve less capacity than required. (cherry picked from commit d009d73) Co-authored-by: Alessandro Decina <alessandro.d@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reserve(additional)reservesadditionalbytes on top of the current length not capacity. Before this fix we could potentially reserve less capacity than required.