-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clean feature: no_overflow_rent_distribution #34074
clean feature: no_overflow_rent_distribution #34074
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34074 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 819 819
Lines 219338 219302 -36
=========================================
- Hits 179695 179615 -80
- Misses 39643 39687 +44 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (sorry for delayed review..)
i've completely forget about this. thanks for cleaning up instead of me. :)
b4a80ec
to
d20145b
Compare
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
@ryoqun thanks for the approval, can you check once more after I fixed conflicts with master? And btw, the v1.17 label was just so that I could test that the new mergify comment automation is working correctly 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-lgtm
Problem
no_overflow_rent_distribution
(#12112) is activated on all clusters and should be cleaned up. I noticed it when doing some other fee related changes.