Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean feature: no_overflow_rent_distribution #34074

Conversation

jstarry
Copy link
Member

@jstarry jstarry commented Nov 15, 2023

Problem

no_overflow_rent_distribution (#12112) is activated on all clusters and should be cleaned up. I noticed it when doing some other fee related changes.

@jstarry jstarry requested a review from ryoqun November 15, 2023 10:09
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #34074 (d20145b) into master (c6451e9) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #34074     +/-   ##
=========================================
- Coverage    81.9%    81.9%   -0.1%     
=========================================
  Files         819      819             
  Lines      219338   219302     -36     
=========================================
- Hits       179695   179615     -80     
- Misses      39643    39687     +44     

ryoqun
ryoqun previously approved these changes Nov 27, 2023
Copy link
Member

@ryoqun ryoqun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (sorry for delayed review..)

i've completely forget about this. thanks for cleaning up instead of me. :)

@jstarry jstarry force-pushed the clean-feature/no_overflow_rent_distribution branch from b4a80ec to d20145b Compare November 27, 2023 04:36
@jstarry jstarry added the v1.17 PRs that should be backported to v1.17 label Nov 27, 2023
Copy link
Contributor

mergify bot commented Nov 27, 2023

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

@jstarry jstarry removed the v1.17 PRs that should be backported to v1.17 label Nov 27, 2023
@jstarry
Copy link
Member Author

jstarry commented Nov 27, 2023

@ryoqun thanks for the approval, can you check once more after I fixed conflicts with master?

And btw, the v1.17 label was just so that I could test that the new mergify comment automation is working correctly 😄

Copy link
Member

@ryoqun ryoqun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-lgtm

@jstarry jstarry added the automerge Merge this Pull Request automatically once CI passes label Nov 27, 2023
@mergify mergify bot merged commit 57ec207 into solana-labs:master Nov 27, 2023
35 checks passed
@jstarry jstarry deleted the clean-feature/no_overflow_rent_distribution branch November 28, 2023 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants