Uses RENT_EXEMPT_RENT_EPOCH to mark account as rent exempt
#34090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
added
the
automerge
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34090 +/- ##
=======================================
Coverage 81.9% 81.9%
=======================================
Files 812 812
Lines 219737 219737
=======================================
+ Hits 180028 180063 +35
+ Misses 39709 39674 -35 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
While reviewing #33945, I noticed that when we set a new account's rent epoch to be rent exempt, we aren't using the
RENT_EXEMPT_RENT_EPOCHconstant. This isn't a correctness problem, but I did initially miss this usage in my search because I was grepping for the constant. Maybe this has happened to others as well.Summary of Changes
Use the constant instead.