Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

propagates the new contact-info through gossip #34092

Merged
merged 1 commit into from
Nov 15, 2023
Merged

propagates the new contact-info through gossip #34092

merged 1 commit into from
Nov 15, 2023

Conversation

behzadnouri
Copy link
Contributor

Problem

Working towards migrating from legacy contact-info to the new contact-info: #29596

Summary of Changes

The commit propagates the new contact-info through gossip.

@behzadnouri
propagates the new contact-info through gossip
213f625 
Working towards migrating from legacy contact-info to the new
contact-info:
solana-labs#29596
gregcusack
gregcusack approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@gregcusack gregcusack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov Codecov
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #34092 (213f625) into master (f005075) will increase coverage by 0.0%.
Report is 6 commits behind head on master.
The diff coverage is 90.0%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #34092   +/-   ##
=======================================
  Coverage    81.9%    81.9%           
=======================================
  Files         812      812           
  Lines      219737   219678   -59     
=======================================
- Hits       180028   180007   -21     
+ Misses      39709    39671   -38

@behzadnouri behzadnouri merged commit ba0a49b into solana-labs:master Nov 15, 2023
32 checks passed
@behzadnouri behzadnouri deleted the gossip-new-contact-info branch November 15, 2023 19:02
@behzadnouri behzadnouri added the v1.17 PRs that should be backported to v1.17 label Nov 15, 2023
mergify bot pushed a commit that referenced this pull request Nov 15, 2023
@behzadnouri @mergify
propagates the new contact-info through gossip (#34092)
a0d28b2 
Working towards migrating from legacy contact-info to the new
contact-info:
#29596

(cherry picked from commit ba0a49b)
@mergify mergify bot mentioned this pull request Nov 15, 2023
Merged
mergify bot added a commit that referenced this pull request Nov 15, 2023
@mergify @behzadnouri
v1.17: propagates the new contact-info through gossip (backport of #3…
7a198e8 
…4092) (#34095)

propagates the new contact-info through gossip (#34092)

Working towards migrating from legacy contact-info to the new
contact-info:
#29596

(cherry picked from commit ba0a49b)

Co-authored-by: behzad nouri <behzadnouri@gmail.com>
@HaoranYi HaoranYi mentioned this pull request Apr 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregcusack gregcusack gregcusack approved these changes

Assignees
No one assigned
Labels
v1.17 PRs that should be backported to v1.17
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@behzadnouri @gregcusack