[zk-token-proof] Feature gate transfer with fee related proofs #34103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34103 +/- ##
==========================================
Coverage 81.8% 81.9%
==========================================
Files 766 818 +52
Lines 209077 219940 +10863
==========================================
+ Hits 171130 180224 +9094
- Misses 37947 39716 +1769 |
samkim-crypto
added
v1.17
joncinque
previously approved these changes
Nov 16, 2023
Yep, I will put in a new feature gate for the zk proof program. |
joncinque
approved these changes
Nov 16, 2023
mergify bot
pushed a commit
that referenced
this pull request
Nov 17, 2023
feature gate zk-token-proof transfer with fee (cherry picked from commit a8863bd) # Conflicts: # sdk/src/feature_set.rs
samkim-crypto
added a commit
that referenced
this pull request
Nov 17, 2023
… (backport of #34103) (#34129) * [zk-token-proof] Feature gate transfer with fee related proofs (#34103) feature gate zk-token-proof transfer with fee (cherry picked from commit a8863bd) # Conflicts: # sdk/src/feature_set.rs * resolve conflict --------- Co-authored-by: samkim-crypto <skim13@cs.stanford.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The confidential transfer with fee part of the token-2022 is targeting 1.18.
Summary of Changes
Add feature gate for processing zk token proof instructions related to transfer with fee.
Fixes #