log when appending exceeds available space #34170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34170 +/- ##
=======================================
Coverage 81.9% 81.9%
=======================================
Files 812 812
Lines 219737 219738 +1
=======================================
+ Hits 180028 180066 +38
+ Misses 39709 39672 -37 |
brooksprumo
approved these changes
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some ancient append vec code triggered the old code in append vecs that previously allowed multiple append vecs per slot. This code will shortly result in an assert. It would be nice to remove this code path at some point.
In the meantime, it would help with diagnosing what caused the situation if we logged some information about what was going on.
Summary of Changes
Add some logging when appending accounts exhausts all space in an append vec.
Fixes #