remaining_bytes aligns len since all writes will align first #34171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34171 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 819 819
Lines 220168 220189 +21
=========================================
- Hits 180441 180428 -13
- Misses 39727 39761 +34 |
HaoranYi
reviewed
Nov 20, 2023
accounts-db/src/accounts_db.rs
Outdated
| @@ -5752,7 +5752,7 @@ impl AccountsDb { | |||
| fn has_space_available(&self, slot: Slot, size: u64) -> bool { | |||
| let store = self.storage.get_slot_storage_entry(slot).unwrap(); | |||
| if store.status() == AccountStorageStatus::Available | |||
| && (store.accounts.capacity() - store.accounts.len() as u64) > size | |||
| && store.accounts.remaining_bytes() > size | |||
There was a problem hiding this comment.
Since we are fixing remaining bytes, has_space_available should be fixed too, stay consistent. right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ancient append vec appending relies on a reliable count of remaining bytes. It turns out that the append vec's
len()is up to the last written byte. This can be non-u64 aligned. The result is if we are to append more to the file, the first operation will be au64_align!. This means thatremaining_byteswas reporting too many bytes. Not all those bytes could be written to, thanks to the bytes wasted for alignment. The result was that writes could fail, causing an attempt at creating a second append vec for the slot. This is no longer allowed and will fail with an assert.Summary of Changes
Align
len()so that remaining bytes returns an accurate number.Fixes #