Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG for new scheduler support #34181

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

apfitzge
Copy link
Contributor

Problem

I did not update the CHANGELOG in #33890, which enabled this option, because I was waiting to merge a few metrics PRs first.
Those have been merged, so updating the change log now.

Summary of Changes

Add changelog line which lists new --block-production-method central-scheduler option

Fixes #

tao-stones
tao-stones previously approved these changes Nov 20, 2023
Copy link
Contributor

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice!

willhickey
willhickey previously approved these changes Nov 27, 2023
Copy link
Contributor

@willhickey willhickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@apfitzge
Copy link
Contributor Author

Had to push a fix for conflict with #34228. @taozhu-chicago or @willhickey could I get re-approval on this?

@apfitzge apfitzge dismissed stale reviews from willhickey and tao-stones via 1de5b32 November 27, 2023 20:15
@tao-stones
Copy link
Contributor

33 files changed 😱

@apfitzge
Copy link
Contributor Author

33 files changed 😱

? It should be a +1 change. Maybe it was displaying incorrectly after rebase due to the github issues today: https://www.githubstatus.com/incidents/66vhjmd266r9

Appears to have been resolved now.

Copy link
Contributor

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (again:D)

@apfitzge apfitzge added the automerge Merge this Pull Request automatically once CI passes label Nov 27, 2023
@mergify mergify bot merged commit 564f1a9 into solana-labs:master Nov 27, 2023
18 checks passed
@apfitzge apfitzge deleted the scheduler-change-log branch November 27, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants