-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CHANGELOG for new scheduler support #34181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Had to push a fix for conflict with #34228. @taozhu-chicago or @willhickey could I get re-approval on this? |
33 files changed 😱 |
21aaf6e
to
1de5b32
Compare
? It should be a +1 change. Maybe it was displaying incorrectly after rebase due to the github issues today: https://www.githubstatus.com/incidents/66vhjmd266r9 Appears to have been resolved now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (again:D)
Problem
I did not update the CHANGELOG in #33890, which enabled this option, because I was waiting to merge a few metrics PRs first.
Those have been merged, so updating the change log now.
Summary of Changes
Add changelog line which lists new
--block-production-method central-scheduler
optionFixes #