check vote costs against block limits in would_fit

[apfitzge]

Problem

CostTracker::would_fit incorrectly not checking votes against block limits.
Introduced in #33230

Summary of Changes

Remove the else so we check against block limits regardless of is_simple_vote.

Fixes #

[apfitzge]

IMO, this should be backported to v1.17, as that is when the bug was introduced.
If #29595 (2ry7ygxiYURULZCrypHhveanvP5tzZ4toRwVp89oCNSj) is activated, this would become a consensus breaking bug.

[tao-stones]

lgtm

[tao-stones]

IMO, this should be backported to v1.17, as that is when the bug was introduced. If #29595 (2ry7ygxiYURULZCrypHhveanvP5tzZ4toRwVp89oCNSj) is activated, this would become a consensus breaking bug.

Agree that it is better to backport it to 1.17, considering overpacking votes could delay reply beyond 400ms

[mergify]

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.