v1.17: direct_mapping: fix iter_memory_pair_chunks in reverse mode (backport of #34204) #34236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
iter_memory_pair_chunks was iterating regions in reverse, but not memory _within_ regions in reverse. This commit fixes the issue and simplifies the implementation by removing nested loops which made control flow hard to reason about. (cherry picked from commit 0908882)
Lichtso
approved these changes
Nov 27, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v1.17 #34236 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 803 803
Lines 217995 218013 +18
=========================================
- Hits 178471 178462 -9
- Misses 39524 39551 +27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #34204 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com