Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.17: bigtable: fix AccessToken issues (backport of #34213) #34238

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 27, 2023

This is an automatic backport of pull request #34213 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* bigtable: fix AccessToken issue

* remove inner

* less changes

* fmt + drop lock

(cherry picked from commit 873bef9)
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #34238 (6f1e083) into v1.17 (4d79fd7) will decrease coverage by 0.1%.
The diff coverage is 0.0%.

Additional details and impacted files
@@            Coverage Diff            @@
##            v1.17   #34238     +/-   ##
=========================================
- Coverage    81.8%    81.8%   -0.1%     
=========================================
  Files         803      803             
  Lines      218013   218020      +7     
=========================================
- Hits       178469   178441     -28     
- Misses      39544    39579     +35     

Copy link
Contributor

@willhickey willhickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Approved for backport since this fixes a bug and is low risk.

@CriesofCarrots CriesofCarrots merged commit 67bfb48 into v1.17 Nov 28, 2023
31 checks passed
@CriesofCarrots CriesofCarrots deleted the mergify/bp/v1.17/pr-34213 branch November 28, 2023 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants