bigtable: remove extra clones #34239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
stale
|
@CriesofCarrots what can I do to make it merged? We do not need to clone |
|
Ohai. I assumed you changed your mind on this, since you didn't include it as a separate commit as I suggested. |
|
Also, looks like you'll need to rebase to pick up the audit fix |
fanatid
force-pushed
the
bt-remove-extra-clones
branch
from
ad8cc3d
to
1f17f4e
Compare
|
Updated! |
CriesofCarrots
approved these changes
Dec 20, 2023
CriesofCarrots
added
automerge
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #34239 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 822 822
Lines 221575 221573 -2
=========================================
- Hits 181440 181342 -98
- Misses 40135 40231 +96 |
|
Thank you! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extracted from #34213
Right now we clone
AccessTokenon every request to BigTable, also we clone it when making a token refresh. InsideAccessTokenwe clone Credentials struct which contains few strings and also clone 2 Arc. We can wrap everything into one Arc and significantly reduce the number of clones.