Trailing _us for scheduler time metrics #34263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apfitzge
force-pushed
the
fix_timing_metrics_names
branch
from
a151364
to
6bee29c
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34263 +/- ##
=======================================
Coverage 81.9% 81.9%
=======================================
Files 819 819
Lines 219741 219741
=======================================
+ Hits 180062 180089 +27
+ Misses 39679 39652 -27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
metrics should be clear on unit
Summary of Changes
add trailing _us to timing metrics
Fixes #