v1.17: shred: expose merkle root for use in blockstore (backport of #34063) #34291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
|
Looks like need to backport |
|
good catch, repopened #34028 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v1.17 #34291 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 803 803
Lines 218110 218135 +25
=========================================
- Hits 178570 178565 -5
- Misses 39540 39570 +30 |
AshwinSekar
force-pushed
the
mergify/bp/v1.17/pr-34063
branch
from
9fbd65b
to
ac22b02
Compare
|
necessary for the backport chain to #34270 |
* shred: expose merkle root for use in blockstore * pr feedback: sorted, keep Result return type * convert Result<Hash> -> Option<Hash> (cherry picked from commit 6a5b8e8)
AshwinSekar
force-pushed
the
mergify/bp/v1.17/pr-34063
branch
from
ac22b02
to
9e5b80f
Compare
behzadnouri
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #34063 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com