Cleanup - program runtime #34318
Merged
Cleanup - program runtime #34318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n remove_programs_with_no_entries() already.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34318 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 819 819
Lines 220228 220219 -9
=========================================
- Hits 180535 180521 -14
- Misses 39693 39698 +5 |
seanyoung
previously approved these changes
Dec 5, 2023
Comment on lines
652
to
656
| *second_level = second_level | ||
| .iter() | ||
| .filter(|entry| entry.deployment_slot != slot) | ||
| .cloned() | ||
| .collect(); |
There was a problem hiding this comment.
looks like a open-coded vec retain, i.e. could be second_level.retain(|entry| entry.deployment_slot != slot);
Lichtso
force-pushed
the
cleanup/program-runtime
branch
from
8d60aca
to
04af227
Compare
seanyoung
approved these changes
Dec 6, 2023
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
mergify bot
pushed a commit
that referenced
this pull request
Dec 12, 2023
* Removes retain() from prune_by_deployment_slot() as that is covered in remove_programs_with_no_entries() already. * Removes remove_programs_with_no_entries() from sort_and_unload(). * Fixes ix_usage_counter in LoadedProgram::to_unloaded(). * Fixes doc comment of LoadedProgram::ix_usage_counter. * Removes unused num_total_programs from test_eviction(). * Replaces .as_ref() in lambda with std::option::Option::as_ref. * Replaces .for_each() with a for-loop. * Uses .retain() instead of iter().filter().cloned().collect(). (cherry picked from commit cf0c52c)
Lichtso
added a commit
that referenced
this pull request
Dec 12, 2023
Cleanup - program runtime (#34318) * Removes retain() from prune_by_deployment_slot() as that is covered in remove_programs_with_no_entries() already. * Removes remove_programs_with_no_entries() from sort_and_unload(). * Fixes ix_usage_counter in LoadedProgram::to_unloaded(). * Fixes doc comment of LoadedProgram::ix_usage_counter. * Removes unused num_total_programs from test_eviction(). * Replaces .as_ref() in lambda with std::option::Option::as_ref. * Replaces .for_each() with a for-loop. * Uses .retain() instead of iter().filter().cloned().collect(). (cherry picked from commit cf0c52c) Co-authored-by: Alexander Meißner <AlexanderMeissner@gmx.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The program runtime crate was reviewed, this PR addresses the informational points.