-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
makes last erasure batch size >= 64 shreds #34330
makes last erasure batch size >= 64 shreds #34330
Conversation
e23cc55
to
8ed373a
Compare
8ed373a
to
dec3e86
Compare
@@ -2562,6 +2562,7 @@ fn run_test_load_program_accounts_partition(scan_commitment: CommitmentConfig) { | |||
|
|||
#[test] | |||
#[serial] | |||
#[ignore] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test is already flaky: #32863 but fails a lot more with this code.
I have to ignore it for now for CI to pass, since this code is not the culprit anyways.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34330 +/- ##
=========================================
- Coverage 82.0% 82.0% -0.1%
=========================================
Files 819 819
Lines 220598 220625 +27
=========================================
+ Hits 180898 180914 +16
- Misses 39700 39711 +11 |
how expensive is it to pad with 32 - d data shreds instead? not saying it can't be done, but introduces some more complexity on the verification side. |
From erasure coding perspective, it would be pretty wasteful to add more empty data shreds instead of coding shreds. |
84bf708
to
25afd71
Compare
25afd71
to
6043a51
Compare
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
(cherry picked from commit 7500235)
Problem
wider retransmitter set for last erasure batch.
Summary of Changes
makes last erasure batch size >= 64 shreds