Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup feature code after activated everywhere #34359

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

tao-stones
Copy link
Contributor

Problem

feature 5Pecy6ie6XGm22pc9d4P9W5c31BugcFBuy6hsP2zkETv checked arithmetic in fee validation #31273 has been activated everywhere.

Summary of Changes

  • cleanup feature code

Fixes #

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #34359 (2fd0ee7) into master (f6403e3) will increase coverage by 0.0%.
Report is 1 commits behind head on master.
The diff coverage is 100.0%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #34359   +/-   ##
=======================================
  Coverage    81.9%    82.0%           
=======================================
  Files         819      819           
  Lines      220583   220562   -21     
=======================================
+ Hits       180862   180874   +12     
+ Misses      39721    39688   -33     

@tao-stones tao-stones marked this pull request as ready for review December 12, 2023 22:47
Copy link
Contributor

@apfitzge apfitzge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Sole usage of checked_arithmetic_in_fee_validation is in feature_set.rs

@tao-stones tao-stones merged commit 69706be into solana-labs:master Dec 14, 2023
34 checks passed
@tao-stones tao-stones deleted the cleanup-feature-31273 branch December 14, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants