add requested limits to static meta #34361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tao-stones
force-pushed
the
runtime-transaction-add-compute-budget-limits
branch
from
e785c15
to
4b71eca
Compare
tao-stones
commented
Dec 7, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34361 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 819 819
Lines 220831 220889 +58
=========================================
+ Hits 180794 180795 +1
- Misses 40037 40094 +57 |
tao-stones
force-pushed
the
runtime-transaction-add-compute-budget-limits
branch
from
6f1acb1
to
b127c5f
Compare
apfitzge
reviewed
Dec 13, 2023
…_set; update requested limits as flat fields of static meta without expiry
tao-stones
force-pushed
the
runtime-transaction-add-compute-budget-limits
branch
from
b127c5f
to
61cdcd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Adding requested limits with expiry, currently set via ComputeBudgetInstructions, to runtime-transaction's static meta.
Summary of Changes
struct RequestedLimitsWithExpiryto tag compute_budget_limits with expiry (eg last slot of current epoch)compute_budget_limitsinto flat fields, add toStaticMeta, avoiding exposing compute_budget stuff to callsite.Fixes #