replay: feature flag consumption of duplicate proofs from blockstore #34372
Conversation
AshwinSekar
added
feature-gate
AshwinSekar
force-pushed
the
blockstore-dup-proof-ff
branch
from
27f0cfd
to
b4ef71b
Compare
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34372 +/- ##
=========================================
- Coverage 81.9% 81.8% -0.1%
=========================================
Files 819 819
Lines 220998 221008 +10
=========================================
- Hits 181019 180967 -52
- Misses 39979 40041 +62 |
AshwinSekar
force-pushed
the
blockstore-dup-proof-ff
branch
from
b4ef71b
to
007b317
Compare
|
How about this? also adding @bw-solana to review since he reviewed original change. |
Yeah, it should be really minor because it's only during startup, but it impacts fork choice |
AshwinSekar
force-pushed
the
blockstore-dup-proof-ff
branch
from
007b317
to
8af9e42
Compare
| .filter_map(|slot| bank_forks.bank_hash(slot).map(|hash| (slot, hash))); | ||
| let duplicate_slot_hashes = duplicate_slots.filter_map(|slot| { | ||
| let bank = bank_forks.get(slot)?; | ||
| bank.feature_set |
There was a problem hiding this comment.
Nit: could probably just check this once and set duplicate_slot_hashes to None when it's inactive
There was a problem hiding this comment.
the problem is that the duplicate_slots_iterator could return slots from different epochs if the restart was performed right after the boundary, so I opted to check it for each bank.
…kstore (backport of #34372) (#34515) * replay: feature flag consumption of duplicate proofs from blockstore (#34372) * replay: feature flag consumption of duplicate proofs from blockstore * pr feedback: reorder check, add flag for restart logic (cherry picked from commit 4a8d27d) # Conflicts: # sdk/src/feature_set.rs * fix feature set conflict --------- Co-authored-by: Ashwin Sekar <ashwin@solana.com>
Problem
#32962 needs to be feature flagged as it could cause a divergence in fork choice.
Summary of Changes
Add a feature gate to ensure smooth rollout to 1.17