Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spl: Bump token-2022 to v1 #34412

Merged
merged 4 commits into from
Dec 22, 2023
Merged

spl: Bump token-2022 to v1 #34412

merged 4 commits into from
Dec 22, 2023

Conversation

joncinque
Copy link
Contributor

Problem

Token-2022 v1 has been deployed to all networks, but the monorepo is still on v0.9.

Summary of Changes

Update token-2022 to v1 and all other required SPL dependencies. The changes in the account decoder and transaction status are all to support the new token-group extensions:

  • group pointer and group member pointer are just like metadata pointer
  • token group and token group member are implementations of the token group interface

Note that there's no parsing of the token group interface instructions here, even though token-2022 implements processors for those instructions.

Fixes #

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 91 lines in your changes are missing coverage. Please review.

Comparison is base (39a3566) 81.9% compared to head (671b588) 81.8%.
Report is 100 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #34412     +/-   ##
=========================================
- Coverage    81.9%    81.8%   -0.1%     
=========================================
  Files         819      821      +2     
  Lines      220984   221332    +348     
=========================================
+ Hits       181015   181131    +116     
- Misses      39969    40201    +232     

Copy link
Contributor

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience! Lgtm

@joncinque joncinque added the v1.17 PRs that should be backported to v1.17 label Dec 22, 2023
@joncinque joncinque merged commit 8a8466c into solana-labs:master Dec 22, 2023
46 checks passed
@joncinque joncinque deleted the tk22bump branch December 22, 2023 01:19
Copy link
Contributor

mergify bot commented Dec 22, 2023

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

mergify bot pushed a commit that referenced this pull request Dec 22, 2023
* Update toml and lockfiles

* account-decoder: Add group and group member extensions

* transaction-status: Add token group + pointer extensions

* program-test: Update token-2022 binary

(cherry picked from commit 8a8466c)

# Conflicts:
#	Cargo.toml
joncinque added a commit that referenced this pull request Dec 22, 2023
* spl: Bump token-2022 to v1 (#34412)

* Update toml and lockfiles

* account-decoder: Add group and group member extensions

* transaction-status: Add token group + pointer extensions

* program-test: Update token-2022 binary

(cherry picked from commit 8a8466c)

# Conflicts:
#	Cargo.toml

* Fix merge conflicts

---------

Co-authored-by: Jon Cinque <me@jonc.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.17 PRs that should be backported to v1.17
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants