ledger-tool: Condense repeated error handling #34439
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a split out from #34426
Problem
Several commands call
load_and_process_ledger()
which can fail in a number of ways. These callers currently all handle the result in the same way by matching the return Result:Ok(_)
case uses the returned types as normalErr(_)
case prints an error message and exitsThis error handling is redundant, and a helper could remove the duplicate code
Summary of Changes
load_and_process_ledger_or_exit()
, a wrapper forload_and_process_ledger()
that unwraps OR prints an error message and returns forErr
load_and_process_ledger_or_exit()
in all previous callers ofload_and_process_ledger()
cargo fmt
to remove the level of indentation from previous callers