Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set root slot/epoch in cache constructor #34447

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

pgarg66
Copy link
Contributor

@pgarg66 pgarg66 commented Dec 13, 2023

Problem

The root slot/epoch are integral part of the program cache, and must be initialized in new().

Summary of Changes

  • remove default implementation of cache
  • add a constructor new() that takes root slot/epoch as parameters and sets it in the cache
  • update bank to call the new constructor.

Fixes #

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #34447 (df01438) into master (2dfcdce) will increase coverage by 0.0%.
Report is 3 commits behind head on master.
The diff coverage is 94.4%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #34447   +/-   ##
=======================================
  Coverage    81.8%    81.8%           
=======================================
  Files         819      819           
  Lines      220923   220927    +4     
=======================================
+ Hits       180870   180928   +58     
+ Misses      40053    39999   -54     

@Lichtso Lichtso merged commit 47dab26 into solana-labs:master Dec 14, 2023
34 checks passed
@pgarg66 pgarg66 added the v1.17 PRs that should be backported to v1.17 label Dec 14, 2023
@pgarg66 pgarg66 deleted the init-root-cache branch December 14, 2023 13:27
Copy link
Contributor

mergify bot commented Dec 14, 2023

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

mergify bot pushed a commit that referenced this pull request Dec 14, 2023
(cherry picked from commit 47dab26)

# Conflicts:
#	program-runtime/src/loaded_programs.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.17 PRs that should be backported to v1.17
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants