Removes unnecessary AccountsDb::new_with_config_for_benches() #34484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34484 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 820 820
Lines 220799 220790 -9
=========================================
- Hits 180706 180653 -53
- Misses 40093 40137 +44 |
steviez
reviewed
Dec 18, 2023
steviez
previously approved these changes
Dec 18, 2023
brooksprumo
force-pushed
the
accounts/ctor-refactor/accounts_db_new_with_config_for_benches-on-master
branch
from
4e014ec
to
3ce189f
Compare
|
Ah bummer, I needed to resolve conflicts (likely because I merged #34485 first), so I've force-pushed those changes. Nothing within the PR has changed though. |
steviez
approved these changes
Dec 18, 2023
brooksprumo
added
the
automerge
mergify
bot
removed
the
automerge
|
automerge label removed due to a CI failure |
brooksprumo
deleted the
accounts/ctor-refactor/accounts_db_new_with_config_for_benches-on-master
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There are too many AccountsDb constructors. AccountsDb::new_with_config_for_benches() is unnecessary. The current callers can new
AccountsDb::new_with_config()instead.Summary of Changes
Remove AccountsDb::new_with_config_for_benches() and update callers.