changelog: add getSignaturesForAddress ordering #34510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As per some conversation on the Telegram RPC channel, we should make the RPC-output changes in #33419 more obvious
Summary of Changes
Add to changelog
Some additional details for posterity: before #33419 , for multiple addresses within the same block, those pulled from local Blockstore were returned in signature order, whereas those from Bigtable were returned in block-inclusion order. This meant, for nodes backed by Bigtable, there were inconsistencies in return data over time and at the boundary between local Blockstore ledger and Bigtable (
minimumLedgerSlot).After the change, ordering will be consistent regardless of which data store a particular slot is queried from.