ledger-tool: make read_only consistent across bigtable subcommands #34513
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
LedgerStorageConfig
contains aread_only
field, but this isn't being populated correctly for somesolana-ledger-tool bigtable
subcommands. This could be a footgun for the CLI if someone modifiedsolana-storage-bigtable
methods to mutate the bigtable without handling appropriately insolana-ledger-tool
.Summary of Changes
Set more subcommands as read-only
I did confirm the setting works as intended, and prevents a block upload when set. However, the CLI just hangs indefinitely on
Preparing the next 1 blocks for upload
, which isn't very clear. I'll look at making that error out properly.