Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-install-all: use full path for sourcing #34525

Merged

Conversation

CriesofCarrots
Copy link
Contributor

Problem

scripts/cargo-install-all.sh breaks when run outside the solana directory: https://discord.com/channels/428295358100013066/670512312339398668/1186583553325142077
This is because source isn't handling the relative path to spl-token-cli-version.sh correctly

Summary of Changes

Use full path instead

@CriesofCarrots CriesofCarrots added v1.16 PRs that should be backported to v1.16 v1.17 PRs that should be backported to v1.17 labels Dec 19, 2023
Copy link
Contributor

mergify bot commented Dec 19, 2023

Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule.

Copy link
Contributor

mergify bot commented Dec 19, 2023

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

Copy link
Contributor

@willhickey willhickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CriesofCarrots CriesofCarrots merged commit 51c9963 into solana-labs:master Dec 19, 2023
18 checks passed
mergify bot pushed a commit that referenced this pull request Dec 19, 2023
Use full path for sourcing

(cherry picked from commit 51c9963)
mergify bot pushed a commit that referenced this pull request Dec 19, 2023
Use full path for sourcing

(cherry picked from commit 51c9963)
mergify bot added a commit that referenced this pull request Dec 19, 2023
) (#34527)

cargo-install-all: use full path for sourcing (#34525)

Use full path for sourcing

(cherry picked from commit 51c9963)

Co-authored-by: Tyera <tyera@solana.com>
mergify bot added a commit that referenced this pull request Dec 19, 2023
) (#34528)

cargo-install-all: use full path for sourcing (#34525)

Use full path for sourcing

(cherry picked from commit 51c9963)

Co-authored-by: Tyera <tyera@solana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.16 PRs that should be backported to v1.16 v1.17 PRs that should be backported to v1.17
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants