Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.17: ledger-tool: support v0 transactions in blocks from bigtable (backport of #34544) #34550

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 20, 2023

This is an automatic backport of pull request #34544 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Support v0 transactions

(cherry picked from commit 7d209a4)
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b9aaedb) 81.8% compared to head (12e20ce) 81.8%.
Report is 1 commits behind head on v1.17.

Additional details and impacted files
@@            Coverage Diff            @@
##            v1.17   #34550     +/-   ##
=========================================
- Coverage    81.8%    81.8%   -0.1%     
=========================================
  Files         803      803             
  Lines      218231   218231             
=========================================
- Hits       178546   178519     -27     
- Misses      39685    39712     +27     

@CriesofCarrots CriesofCarrots added the automerge Merge this Pull Request automatically once CI passes label Dec 20, 2023
@mergify mergify bot removed the automerge Merge this Pull Request automatically once CI passes label Dec 21, 2023
Copy link
Contributor Author

mergify bot commented Dec 21, 2023

automerge label removed due to a CI failure

@CriesofCarrots CriesofCarrots added the automerge Merge this Pull Request automatically once CI passes label Dec 21, 2023
@mergify mergify bot merged commit ef1fb9e into v1.17 Dec 21, 2023
32 checks passed
@mergify mergify bot deleted the mergify/bp/v1.17/pr-34544 branch December 21, 2023 05:56
@CriesofCarrots
Copy link
Contributor

Weird, I don't know why mergify removed the label the first time.

@steviez
Copy link
Contributor

steviez commented Dec 21, 2023

Weird, I don't know why mergify removed the label the first time.

clippy (mac os-latest) failed for a spurious reason and I hit retry; sorry if this caused any confusion that you spent time digging on.

image

@CriesofCarrots
Copy link
Contributor

Oh, ha that makes sense. That dropdown that shows the failure is a bit subtle!
Thank you for doing that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants