Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: ignore farf/ in .gitignore #34634

Merged
merged 3 commits into from
Jan 3, 2024
Merged

chore: ignore farf/ in .gitignore #34634

merged 3 commits into from
Jan 3, 2024

Conversation

HaoranYi
Copy link
Contributor

@HaoranYi HaoranYi commented Jan 3, 2024 •
edited
Loading

Problem

we should ignore all farf dirs in .gitignore.

Summary of Changes

add farf/ to git ignore

Fixes #

@HaoranYi HaoranYi changed the title add test-validator/farf/ to gitignore gitignore: add test-validator/farf/ to gitignore Jan 3, 2024
@HaoranYi HaoranYi changed the title gitignore: add test-validator/farf/ to gitignore chore: add test-validator/farf/ to gitignore Jan 3, 2024
@CriesofCarrots
Copy link
Contributor

Probably should gitignore farf at any dir level

brooksprumo
brooksprumo reviewed Jan 3, 2024
View reviewed changes
Copy link
Contributor

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! I'm guessing you were running the test-validator and it creates a farf directory that showed up in your git?

.gitignore Outdated Show resolved Hide resolved
@HaoranYi
Copy link
Contributor Author

HaoranYi commented Jan 3, 2024

Good idea! I'm guessing you were running the test-validator and it creates a farf directory that showed up in your git?

Yup.

brooksprumo
brooksprumo reviewed Jan 3, 2024
View reviewed changes
Copy link
Contributor

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. Are there more planned changes before marking the PR as ready for review?

@HaoranYi HaoranYi marked this pull request as ready for review January 3, 2024 15:30
brooksprumo
brooksprumo approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brooksprumo
Copy link
Contributor

Can you update the PR's title and description before merging, please?

@HaoranYi HaoranYi changed the title chore: add test-validator/farf/ to gitignore chore: ignore farf/ in .gitignore Jan 3, 2024
@HaoranYi HaoranYi merged commit 8148cb5 into solana-labs:master Jan 3, 2024
15 checks passed
@HaoranYi HaoranYi deleted the 2024_jan_3 branch January 3, 2024 16:36
@willhickey willhickey mentioned this pull request Mar 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brooksprumo brooksprumo brooksprumo approved these changes

@willhickey willhickey Awaiting requested review from willhickey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HaoranYi @CriesofCarrots @brooksprumo