-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes remaining unused accounts data len bits #34732
Removes remaining unused accounts data len bits #34732
Conversation
54bd175
to
171ceae
Compare
/// The change in accounts data len | ||
pub accounts_data_len_delta: i64, | ||
} | ||
pub struct ProcessedMessageInfo {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few options here:
- Change to
pub struct ProcessedMessageInfo;
, without the{}
- Remove the struct entirely
Wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove it entirely
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 0351a8a
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #34732 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 824 824
Lines 222730 222699 -31
=======================================
+ Hits 182293 182339 +46
+ Misses 40437 40360 -77 |
Problem
There are a few more bits of code related to accounts data meter and accounts data len during transaction processing that are now unused.
Summary of Changes
Each logical change is its own commit: